Re: [PATCH v2] statx.2: Add stx_atomic_write_unit_max_opt

[John Garry <john.g.garry@xxxxxxxxxx>]

Hi Alex,

On 19/06/2025 12:05, Alejandro Colomar wrote:
>> @@ -74,6 +74,9 @@ struct statx {
>>   \&
>>       /* File offset alignment for direct I/O reads */
>>       __u32   stx_dio_read_offset_align;
>> +\&
>> +    /* Direct I/O atomic write max opt limit */
>> +    __u32 stx_atomic_write_unit_max_opt;
> Please align the member with the one above.

stx_dio_read_offset_align is actually misaligned (to the member above it):

               /* Direct I/O atomic write limits */
               __u32 stx_atomic_write_unit_min;
               __u32 stx_atomic_write_unit_max;
               __u32 stx_atomic_write_segments_max;

               /* File offset alignment for direct I/O reads */
               __u32   stx_dio_read_offset_align;

I'll just fix that separately.

Thanks,
John