Re: [PATCH v2] statx.2: Add stx_atomic_write_unit_max_opt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

On Thu, Jun 19, 2025 at 12:24:21PM +0100, John Garry wrote:
> > > @@ -514,6 +518,20 @@ is supported on block devices since Linux 6.11.
> > >   The support on regular files varies by filesystem;
> > >   it is supported by xfs and ext4 since Linux 6.13.
> > >   .TP
> > > +.I stx_atomic_write_unit_max_opt
> > > +The maximum size (in bytes) which is optimised for writes issued with
> > > +torn-write protection.
> > 
> > Please break the line before 'optimized' and remove the current line
> > break.
> 
> ok, but I am not sure the issue with the current formatting

It's because of

$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p';
   Use semantic newlines
       In the source of a manual page, new sentences should be  started
       on  new  lines,  long  sentences  should  be split into lines at
       clause breaks (commas, semicolons, colons, and so on), and  long
       clauses  should be split at phrase boundaries.  This convention,
       sometimes known as "semantic newlines", makes it easier  to  see
       the effect of patches, which often operate at the level of indi‐
       vidual sentences, clauses, or phrases.

> > > +.I stx_atomic_write_unit_max
> > > +and will not be less than the value in
> > > +.I stx_atomic_write_unit_min.
> > 
> > This should be IR, and the '.' separated by a space, so that the '.' is
> > not in italics.
> 
> So you mean like the following:
> 
> .IR stx_atomic_write_unit_min .
> 
> right?

Yep.


Cheers,
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux