On Mon 16-06-25 11:21:17, Junxuan Liao wrote: > > > On 6/16/25 5:10 AM, Jan Kara wrote: > > Otherwise the changes look good to me. > > Thanks! Just for clarification, is the __d_move comment accurate? i.e. > Does it assume the two i_rwsem's are locked in shared mode? Currently, both i_rwsems are expected to be held exclusively in this case. Generally anything modifying directory contents must be holding i_rwsem of that directory exclusively. However note that this is subject to change at least in some cases with the work Neil Brown is doing [1]. Honza [1] https://lore.kernel.org/linux-fsdevel/20250609075950.159417-1-neil@xxxxxxxxxx/ -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR