On Thu, May 29, 2025 at 10:25:02AM +0800, Yangtao Li wrote: > +cc Christian Brauner > > 在 2025/5/29 05:26, Viacheslav Dubeyko 写道: > > On Wed, 2025-05-28 at 16:37 +0000, 李扬韬 wrote: > > > Hi Slava, > > > > > > > I am slightly confused by comment. Does it mean that the fix introduces more errors? It looks like we need to have more clear explanation of the fix here. > > > > > > I'll update commit msg. > > > > > > > s->s_flags |= SB_NODIRATIME | SB_NOATIME; > > > > > > IIUC, SB_NOATIME > SB_NODIRATIME. > > > > > > > Semantically, it's two different flags. One is responsible for files and another > > one is responsible for folders. So, this is why I believe it's more safe to have > > these both flags. > > To be honest, from my point of view, SB_NOATIME is more like disabling atime > updates for all types of files, not just files. I would like to know what > vfs people think, whether we need to use both flags at the same time. SB_NODIRATIME should be a subset of SB_NOATIME. So all you should need is SB_NOATIME to disable it for all files.
