回复: [PATCH v2 2/3] hfs: correct superblock flags

[李扬韬 <frank.li@xxxxxxxx>]

Hi Slava,

> I am slightly confused by comment. Does it mean that the fix introduces more errors? It looks like we need to have more clear explanation of the fix here.

I'll update commit msg.

> s->s_flags |= SB_NODIRATIME | SB_NOATIME;

IIUC, SB_NOATIME > SB_NODIRATIME.

So we should correct flags in smb, ceph.

2091 bool atime_needs_update(const struct path *path, struct inode *inode)
2092 {
2093         struct vfsmount *mnt = path->mnt;
2094         struct timespec64 now, atime;
2095
2096         if (inode->i_flags & S_NOATIME)
2097                 return false;
2098
2099         /* Atime updates will likely cause i_uid and i_gid to be written
2100         ¦* back improprely if their true value is unknown to the vfs.
2101         ¦*/
2102         if (HAS_UNMAPPED_ID(mnt_idmap(mnt), inode))
2103                 return false;
2104
2105         if (IS_NOATIME(inode))
2106                 return false;
2107         if ((inode->i_sb->s_flags & SB_NODIRATIME) && S_ISDIR(inode->i_mode))
2108                 return false;

Thx,
Yangtao