On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> Since 5.10, splice() or sendfile() return EINVAL. This was
> caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> without explicit ops").
>
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
> fs/hfs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> index a81ce7a740b9..451115360f73 100644
> --- a/fs/hfs/inode.c
> +++ b/fs/hfs/inode.c
> @@ -692,6 +692,7 @@ static const struct file_operations hfs_file_operations = {
> .write_iter = generic_file_write_iter,
> .mmap = generic_file_mmap,
> .splice_read = filemap_splice_read,
> + .splice_write = iter_file_splice_write,
> .fsync = hfs_file_fsync,
> .open = hfs_file_open,
> .release = hfs_file_release,
Makes sense.
Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>
Thanks,
Slava.
