On Wed, May 14, 2025 at 11:13:27AM +0200, Vlastimil Babka wrote:
> On 5/14/25 10:56, Lorenzo Stoakes wrote:
> >> Fixes: c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file callback")
>
> Ah yeah I missed there wasn't one.
>
> > Is it worth having a fixes tag for something not upstream? This is why I
> > excluded that. I feel like it's maybe more misleading when the commit hashes are
> > ephemeral in a certain branch?
>
> Yeah it can be useful, in case the fixed commit gets backported somewhere,
> tools can warn that there's a follow up fix. As mm-stable hashes should not
> be ephemeral, then this should remain valid (and if there's a rebase for
> some reason then the fix could be squashed).
Yeah the mm-stable hashes not being ephemeral was the bit of information I
was missing, I would have added this tag otherwise!
One day I'll get the hang of this mm stuff... :P
>
> >>
> >> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
> >
> > Thanks!
> >
> >>
> >> --
> >> Cheers,
> >>
> >> David / dhildenb
> >>
>
>
