On 05/06, Eric Sandeen wrote: > On 5/6/25 9:56 PM, Eric Sandeen wrote: > > On 5/6/25 8:23 PM, Jaegeuk Kim wrote: > > ... > > >> What about: > >> # mount -o loop,noextent_cache f2fsfile.img mnt > >> > >> In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, > >> 3) clear_opt since mask is set? > > > > Not sure what I'm missing, it seems to work properly here but I haven't > > pulled your (slightly) modified patches yet: > > > > # mount -o loop,extent_cache f2fsfile.img mnt > > # mount | grep -wo extent_cache > > extent_cache > > # umount mnt > > > > # mount -o loop,noextent_cache f2fsfile.img mnt > > # mount | grep -wo noextent_cache > > noextent_cache > > # > > > > this looks right? > > > > I'll check your tree tomorrow, though it doesn't sound like you made many > > changes. > > Hmm, I checked tonight and I see the same (correct?) behavior in your tree. > > >> And, device_aliasing check is still failing, since it does not understand > >> test_opt(). Probably it's the only case? > > Again, in your tree (I had to use a git version of f2fs-tools to make device > aliasing work - maybe time for a release?) ;) > > # mkfs.ext4 /dev/vdc > # mkfs/mkfs.f2fs -c /dev/vdc@xxxxxxxx /dev/vdb > # mount -o noextent_cache /dev/vdb mnt > # dmesg | tail -n 1 > [ 581.924604] F2FS-fs (vdb): device aliasing requires extent cache > # mount -o extent_cache /dev/vdb mnt > # mount | grep -wo extent_cache > extent_cache > # I meant: # mkfs/mkfs.f2fs -c /dev/vdc@xxxxxxxx /dev/vdb # mount /dev/vdb mnt It's supposed to be successful, since extent_cache is enabled by default. > > Maybe you can show me exactly what's not working for you? > > -Eric
