On 5/6/25 8:23 PM, Jaegeuk Kim wrote: > On 05/06, Eric Sandeen wrote: >> On 5/6/25 7:35 PM, Jaegeuk Kim wrote: >>> Hmm, I had to drop the series at the moment, since it seems needing more >>> work to deal with default_options(), which breaks my device setup. >>> For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not propagating >>> to the below logics. In this case, do we need ctx_set_opt() if user doesn't set? >> >> Hm, can you describe the test or environment that fails for you? >> (I'm afraid that I may not have all the right hardware to test everything, >> so may have missed some cases) >> >> However, from a quick test here, a loopback mount of an f2fs image file does >> set extent_cache properly, so maybe I don't understand the problem: >> >> # mount -o loop f2fsfile.img mnt >> # mount | grep -o extent_cache >> extent_cache >> # >> >> I'm happy to try to look into it though. Maybe you can put the patches >> back on a temporary branch for me to pull and test? > > Thank you! I pushed here the last version. > > https://github.com/jaegeuk/f2fs/commits/mount/ > > What about: > # mount -o loop,noextent_cache f2fsfile.img mnt > > In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, > 3) clear_opt since mask is set? Not sure what I'm missing, it seems to work properly here but I haven't pulled your (slightly) modified patches yet: # mount -o loop,extent_cache f2fsfile.img mnt # mount | grep -wo extent_cache extent_cache # umount mnt # mount -o loop,noextent_cache f2fsfile.img mnt # mount | grep -wo noextent_cache noextent_cache # this looks right? I'll check your tree tomorrow, though it doesn't sound like you made many changes. > And, device_aliasing check is still failing, since it does not understand > test_opt(). Probably it's the only case? I think you can blame me, not Hongbo on that one ;) - I will look into it. -Eric >> >> Thanks, >> - Eric >> >
