On Wed, Apr 30, 2025 at 03:01:10PM -0400, Brian Foster wrote:
> +/* trim pos and bytes to within a given folio */
> +static loff_t iomap_trim_folio_range(struct iomap_iter *iter,
> + struct folio *folio, size_t *offset, u64 *bytes)
> +{
> + loff_t pos = iter->pos;
> + size_t fsize = folio_size(folio);
> +
> + WARN_ON_ONCE(pos < folio_pos(folio) || pos >= folio_pos(folio) + fsize);
Should this be two separate WARN_ON_ONCE calls to see which one
triggered?
> +
> + *offset = offset_in_folio(folio, pos);
> + if (*bytes > fsize - *offset)
> + *bytes = fsize - *offset;
*bytes = min(*bytes, fsize - *offset);
?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
