Re: [PATCH 3/6] iomap: drop pos param from __iomap_[get|put]_folio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 3/6] iomap: drop pos param from __iomap_[get|put]_folio()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 5 May 2025 02:01:33 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20250430190112.690800-4-bfoster@redhat.com>

On Wed, Apr 30, 2025 at 03:01:09PM -0400, Brian Foster wrote:
> Both helpers take the iter and pos as parameters. All callers
> effectively pass iter->pos, so drop the unnecessary pos parameter.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 0/6] iomap: misc buffered write path cleanups and prep
  - From: Brian Foster
- [PATCH 3/6] iomap: drop pos param from __iomap_[get|put]_folio()
  - From: Brian Foster

Prev by Date: Re: [PATCH 2/6] iomap: drop unnecessary pos param from iomap_write_[begin|end]
Next by Date: Re: [PATCH 4/6] iomap: helper to trim pos/bytes to within folio
Previous by thread: Re: [PATCH 3/6] iomap: drop pos param from __iomap_[get|put]_folio()
Next by thread: [PATCH 5/6] iomap: push non-large folio check into get folio path
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux