On Tue, Apr 29, 2025 at 09:22:59AM +0200, Vlastimil Babka wrote: > On 4/28/25 17:28, Lorenzo Stoakes wrote: > > Right now these are performed in kernel/fork.c which is odd and a violation > > of separation of concerns, as well as preventing us from integrating this > > and related logic into userland VMA testing going forward, and perhaps more > > importantly - enabling us to, in a subsequent commit, make VMA > > allocation/freeing a purely internal mm operation. > > I wonder if the last part is from an earlier version and now obsolete > because there's not subsequent commit in this series and the placement of > alloc/freeing in vma_init.c seems making those purely internal mm operations > already? Or do you mean some further plans? > Sorry, missed this! Andrew - could we delete the last part of this sentence so it reads: Right now these are performed in kernel/fork.c which is odd and a violation of separation of concerns, as well as preventing us from integrating this and related logic into userland VMA testing going forward. Thanks!