Song Liu <songliubraving@xxxxxxxx> wrote: > Thanks for the review. I guess we will need the following changes, You need a little bit more. The error handling in the init function also needs #ifdef'ing too lest the compiler warn about unused goto labels. > probably in two separate patches? Hmmm... yes. I'm suddenly uncertain about the order modules are inited. It might actually need to be fs_initcall(). David
