On Fri, Apr 04, 2025 at 10:14:32PM +0200, Mateusz Guzik wrote: > Callers don't need to check it because it is guaranteed to be 0. Also > returning 0 vs returning nothing makes virtually no difference to > anyone. Nom the return value very clearly states it can return something else with your patch, and people will sooner or later do that. Let's stop these silly things that just create nasty landmines for no reason at all. > As for general context, there are several small slowdowns when issuing > fstat() and I'm tackling them bit by bit (and yes, tail calling vs > returning to the caller and that caller exiting is a small > optimization). Please prove that it makes a difference. And if it does do the changes in a sane way by keeping the helper as is except for marking it as inline candidate and a special _tail helper below that inlines it. But the bar for such micro-optimizations should be high, and so far you have no managed to provide any rationale for it.
