On Fri, Apr 04, 2025 at 07:19:27AM -0700, Linus Torvalds wrote: > On Fri, 4 Apr 2025 at 01:28, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > Or just kill the non-scoped guard because it simply is an insane API. > > The scoped guard may be odd, but it's actually rather a common > situation. And when used with the proper indentation, it also ends up > being pretty visually clear about what part of a function is under the > lock. The scoped one with proper indentation is fine. The non-scoped one is the one that is really confusing and odd.