On Mon, Mar 17, 2025 at 09:57:45AM +0000, John Garry wrote: >> And handle the case where there >> is no hardware support at all. > > So xfs_get_atomic_write_max_attr() -> xfs_inode_can_atomicwrite() covers no > HW support. > > The point of this function is just to calc atomic write limits according to > mount point geometry and features. > > Do you think that it is necessary to call xfs_inode_can_atomicwrite() here > also? [And remove the xfs_get_atomic_write_max_attr() -> > xfs_inode_can_atomicwrite()?] At least document what it does.. >>> +static inline void >>> +xfs_compute_awu_max( >> >> And use a more descriptive name than AWU, wich really just is a >> nvme field name. > > I am just trying to be concise to limit spilling lines. > > Maybe atomicwrite_unit_max is preferred I guess if we ant to stick to the unit encoded in awu and used by the block layer, yes.
