On Fri, May 23, 2025 at 10:03:43PM +0800, Zorro Lang wrote:
> On Mon, May 19, 2025 at 06:16:41AM +0000, Nirjhar Roy (IBM) wrote:
> > This patch another optional interactive prompt to enter the
> > author name for each new test file that is created using
> > the "new" file.
> >
> > The sample output looks like something like the following:
> >
> > ./new selftest
> > Next test id is 007
> > Append a name to the ID? Test name will be 007-$name. y,[n]:
> > Creating test file '007'
> > Add to group(s) [auto] (separate by space, ? for list): selftest quick
> > Enter <author_name>: Nirjhar Roy <nirjhar.roy.lists@xxxxxxxxx>
> > Creating skeletal script for you to edit ...
> > done.
> >
> > Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@xxxxxxxxx>
> > ---
> > new | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/new b/new
> > index 6b50ffed..636648e2 100755
> > --- a/new
> > +++ b/new
> > @@ -136,6 +136,9 @@ else
> > check_groups "${new_groups[@]}" || exit 1
> > fi
> >
> > +read -p "Enter <author_name>: " -r
> > +author_name="${REPLY:=YOUR NAME HERE}"
> > +
> > echo -n "Creating skeletal script for you to edit ..."
> >
> > year=`date +%Y`
> > @@ -143,7 +146,7 @@ year=`date +%Y`
> > cat <<End-of-File >$tdir/$id
> > #! /bin/bash
> > # SPDX-License-Identifier: GPL-2.0
> > -# Copyright (c) $year YOUR NAME HERE. All Rights Reserved.
> > +# Copyright (c) $year $author_name. All Rights Reserved.
>
> Dave thought we shouldn't use "author_name" at here:
> https://lore.kernel.org/fstests/aC509xXxgZJKKZVE@xxxxxxxxxxxxxxxxxxx/
>
> If you don't mind, I'll merge PATCH 2/2 this week. If you still hope to
> have the 1/2, please consider the review point from Dave.
Oh, sorry, you've sent a V4... Please ignore this one, I'm going to review
your V4.
>
> Thanks,
> Zorro
>
> > #
> > # FS QA Test $id
> > #
> > --
> > 2.34.1
> >
> >
