On 5/12/25 21:06, Christoph Hellwig wrote:
This still looks good.
Thanks.
One nit:
+ /*
+ * Now that mp has been modified according to the remount options,
+ * we do a final option validation with xfs_finish_flags()
+ * just like it is done during mount. We cannot use
+ * xfs_finish_flags()on new_mp as it contains only the user
+ * given options.
This could use slightly better formatting:
/*
* Now that mp has been modified according to the remount options, we
* do a final option validation with xfs_finish_flags() just like it is
* done during mount. We cannot use xfs_finish_flags() on new_mp as it
* contains only the user given options.
*/
Okay, I will make the change in the next revision.
--NR
--
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore
