This still looks good. One nit: > + /* > + * Now that mp has been modified according to the remount options, > + * we do a final option validation with xfs_finish_flags() > + * just like it is done during mount. We cannot use > + * xfs_finish_flags()on new_mp as it contains only the user > + * given options. This could use slightly better formatting: /* * Now that mp has been modified according to the remount options, we * do a final option validation with xfs_finish_flags() just like it is * done during mount. We cannot use xfs_finish_flags() on new_mp as it * contains only the user given options. */
