Re: [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support

To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Wed, 13 Aug 2025 14:32:05 -0700
Cc: Yibo Dong <dong100@xxxxxxxxx>, Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>, andrew+netdev@xxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, pabeni@xxxxxxxxxx, horms@xxxxxxxxxx, corbet@xxxxxxx, gur.stavi@xxxxxxxxxx, maddy@xxxxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, danishanwar@xxxxxx, lee@xxxxxxxxx, gongfan1@xxxxxxxxxx, lorenzo@xxxxxxxxxx, geert+renesas@xxxxxxxxx, Parthiban.Veerasooran@xxxxxxxxxxxxx, lukas.bulwahn@xxxxxxxxxx, alexanderduyck@xxxxxx, richardcochran@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <CAMuHMdWpmt2q9tVm-3HV1h2=-7D6zEs_HnBe5gfYVgvfB=01hQ@mail.gmail.com>
References: <20250812093937.882045-1-dong100@mucse.com> <20250812093937.882045-5-dong100@mucse.com> <eafb8874-a7a3-4028-a4ad-d71fc5689813@linux.dev> <9A6132D78B40DAFD+20250813095214.GA979548@nic-Precision-5820-Tower> <CAMuHMdWpmt2q9tVm-3HV1h2=-7D6zEs_HnBe5gfYVgvfB=01hQ@mail.gmail.com>

On Wed, 13 Aug 2025 13:05:36 +0200 Geert Uytterhoeven wrote:
> Or use scoped_cond_guard(mutex_intr, ...) { ... }?

Hard no on that in networking.

References:
- [PATCH v3 0/5] Add driver for 1Gbe network chips from MUCSE
  - From: Dong Yibo
- [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support
  - From: Dong Yibo
- Re: [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support
  - From: Vadim Fedorenko
- Re: [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support
  - From: Yibo Dong
- Re: [PATCH v3 4/5] net: rnpgbe: Add basic mbx_fw support
  - From: Geert Uytterhoeven