Em Fri, 01 Aug 2025 08:10:05 -0600
Jonathan Corbet <corbet@xxxxxxx> escreveu:
> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:
>
> > Em Thu, 31 Jul 2025 18:13:19 -0600
> > Jonathan Corbet <corbet@xxxxxxx> escreveu:
> >>
> >> - struct_members = KernRe(type_pattern + r'([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
> >> + struct_members = KernRe(r'(struct|union)([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
> >
> > I would prefer keeping type_pattern here.
>
> The problem is that type_pattern no longer exists in that function.
Ah, I see. If this is the only place now where we have this, then it
sounds OK to have it like that.
Feel free to add my R-B:
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> I'd
> have to redefine it, or make it global. It seems like a rather trivial
> thing to make global (and, as a result, make people go to the top of the
> file to figure out what it really is).
Thanks,
Mauro
