Re: [PATCH 05/12] docs: kdoc: split top-level prototype parsing out of dump_struct()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:

> Em Thu, 31 Jul 2025 18:13:19 -0600
> Jonathan Corbet <corbet@xxxxxxx> escreveu:
>>  
>> -        struct_members = KernRe(type_pattern + r'([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
>> +        struct_members = KernRe(r'(struct|union)([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
>
> I would prefer keeping type_pattern here. 

The problem is that type_pattern no longer exists in that function.  I'd
have to redefine it, or make it global.  It seems like a rather trivial
thing to make global (and, as a result, make people go to the top of the
file to figure out what it really is).

jon




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux