On Thu, 3 Jul 2025 17:40:52 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Wed, Jul 02, 2025 at 11:08:11PM +0000, Lothar Rubusch wrote: > > The patch set covers the following topics: > > - add debug register and regmap cache > > - prepare iio channel scan_type and scan_index > > - prepare interrupt handling > > - implement fifo with watermark > > - add activity/inactivity together with auto-sleep with link bit > > - add ac coupled activity/inactivity, integrate with auto-sleep and link bit > > - documentation > > > > Sorry for the fuzz: when I was about to rebase for submitting I > > noticed Jonathan actually already applied parts of this. I'd recommend > > to consider v6 rather over v5. > > > > Since activity and inactivity here are implemented covering all axis, I > > assumed x&y&z and x|y|z, respectively. Thus the driver uses a fake > > channel for activity/inactiviy. AC-coupling is similar to other Analog Device > > accelerometers, so MAG_ADAPTIVE events are chosen. Combinations are > > documented and functionality tested and verified working. > > Overall LGTM, one nit-pick somewhere, otherwise feel free to add > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > to the rest of the series (which has no my tag yet). > Tweaked as suggested to err_reset_fifo and applied with tag on whole series. J
