Hi Babu, On 6/30/25 1:58 PM, Moger, Babu wrote: > > How does this look? > > "fs/resctrl: Pass struct rdtgroup instead of individual members > > Reading monitoring data for a resctrl group requires both the RMID and > CLOSID. These parameters are passed to functions like __mon_event_count(), > mbm_bw_count(), mbm_update_one_event(), and mbm_update(), where they are > ultimately used to retrieve event data. > > When "mbm_event" counter assignment mode is enabled, a counter ID is > required to read the event. The counter ID is obtained through > mbm_cntr_get(), which expects a struct rdtgroup pointer. > > Passing the pointer to the full rdtgroup structure simplifies access to > these parameters. Refactor the code to pass a pointer to struct rdtgroup > instead of individual members in preparation for this requirement." This looks good. I made a few adjustments that result in below. What do you think? Reading monitoring data for a monitoring group requires both the RMID and CLOSID. The RMID and CLOSID are members of struct rdtgroup but passed separately to several functions involved in retrieving event data. When "mbm_event" counter assignment mode is enabled, a counter ID is required to read event data. The counter ID is obtained through mbm_cntr_get(), which expects a struct rdtgroup pointer. Provide a pointer to the struct rdtgroup as parameter to functions involved in retrieving event data to simplify access to RMID, CLOSID, and counter ID. Reinette
