Hi Babu, On 6/30/25 6:57 AM, Moger, Babu wrote: > Hi Reinette, > > On 6/24/2025 11:18 PM, Reinette Chatre wrote: >> Hi Babu, >> >> On 6/13/25 2:05 PM, Babu Moger wrote: >>> Reading the monitoring data requires RMID, CLOSID, and event ID, among >>> other parameters. These are passed individually, resulting in architecture >> >> It is not clear how "event ID" and "other parameters" are relevant to this >> change since (in this context) it is only RMID and CLOSID that can be >> found in rdtgroup. >> >>> specific function calls. >> >> Could you please elaborate what you meant with: "These are passed individually, >> resulting in architecture specific function calls."? > > Rephrased the whole changelog. > > "fs/resctrl: Pass the full rdtgroup structure instead of individual RMID > and CLOSID nit, can be simplified to: fs/resctrl: Pass struct rdtgroup instead of individual members > > The functions resctrl_arch_reset_rmid() and resctrl_arch_rmid_read() (No need to say "function" when using ().) But wait ... this now changes to different functions from what the original patch touched and even more so it changes _arch_ functions that should not have access to struct rdtgroup. This new changelog does not seem to document the original patch but something new that has not yet been posted. > require several parameters, including RMID and CLOSID. Currently, RMID and > CLOSID are passed individually, even though they are available within the > rdtgroup structure. > > Refactor the code to pass a pointer to struct rdtgroup instead of > individual members in preparation for this requirement. "this requirement" .. what requirement are you referring to? There is no requirement that individual members of a struct cannot be passed as separate parameters and there is no problem doing so.
