Hi Tejun, On 21 May 2025 5:11, Tejun Heo wrote: > > -WARNING: cgroup2 cpu controller doesn't yet fully support the control of > > +WARNING: cgroup2 cpu controller doesn't yet support the (bandwidth) control of > > This reads weird to me. Without the () part, it becomes "doesn't yet support > the control of". Maybe rephrase it a bit more? I'm not sure how to rephrase it. It sounds fine to me 😅 Moreover, "doesn't yet support the control of" was the wording when the warning paragraph on RT_GROUP_SCHED was added in commit c2f31b79 (cgroup: add warning about RT not being supported on cgroup2). Would removing the parentheses, making it "doesn't yet support the bandwidth control of", sound better? Thank you Regards, Shashank ________________________________________ From: Tejun Heo <tj@xxxxxxxxxx> Sent: 21 May 2025 5:11 To: Mahadasyam, Shashank (SGC) Cc: Johannes Weiner; Michal Koutný; Jonathan Corbet; cgroups@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Takumi, Shinya (SGC) Subject: Re: [PATCH v2 1/3] cgroup, docs: be specific about bandwidth control of rt processes On Tue, May 20, 2025 at 11: 07: 45PM +0900, Shashank Balaji via B4 Relay wrote: > From: Shashank Balaji <shashank. mahadasyam@ sony. com> > > Signed-off-by: Shashank Balaji <shashank. mahadasyam@ sony. com> > --- > Documentation/admin-guide/cgroup-v2. rst On Tue, May 20, 2025 at 11:07:45PM +0900, Shashank Balaji via B4 Relay wrote: > From: Shashank Balaji <shashank.mahadasyam@xxxxxxxx> > > Signed-off-by: Shashank Balaji <shashank.mahadasyam@xxxxxxxx> > --- > Documentation/admin-guide/cgroup-v2.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 1a16ce68a4d7f6f8c9070be89c4975dbfa79077e..3b3685736fe9b12e96a273248dfb4a8c62a4b698 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1076,7 +1076,7 @@ cpufreq governor about the minimum desired frequency which should always be > provided by a CPU, as well as the maximum desired frequency, which should not > be exceeded by a CPU. > > -WARNING: cgroup2 cpu controller doesn't yet fully support the control of > +WARNING: cgroup2 cpu controller doesn't yet support the (bandwidth) control of This reads weird to me. Without the () part, it becomes "doesn't yet support the control of". Maybe rephrase it a bit more? Thanks. -- tejun
