On Sun, Apr 27, 2025 at 02:58:03PM +0000, Dr. David Alan Gilbert wrote: > * Mark Brown (broonie@xxxxxxxxxx) wrote: > > Please do some analysis as to why the functions are there, don't just > > blindly delete things. > I'd appreciate some more idea of what you're after; each patch > shows where and when the function was added or last used. Some have Something that indicates that this is a patch written by a human rather than some automated noise, that considers things like API usability and coherence, or what people might do if the API is not available when they need it, rather than just mechanically churning something out. None of your commit logs consider what the code you're deleting does at all. > comments saying things like the devm_ version is being used (so it > seemed reasonable to me to delete the plain version if no one uses it). Deleting the plain version of something where a devm version exists is an obvious example of making the API less coherent and hard to use, managed resources aren't universally appropriate and so you should generally be able to do the same thing with manual resource management.
Attachment:
signature.asc
Description: PGP signature
