Re: [PATCH 0/5] Regulator deadcode cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Mark Brown (broonie@xxxxxxxxxx) wrote:
> On Sat, Apr 26, 2025 at 06:51:38PM +0100, linux@xxxxxxxxxxx wrote:
> 
> >   This is a bunch of deadcode cleanups for functions
> > that are unused (for quite some time).
> >   The first patch was originally sent in October last
> > year but didn't get any traction; the rest are new.
> 
> Please do some analysis as to why the functions are there, don't just
> blindly delete things.

I'd appreciate some more idea of what you're after;  each patch
shows where and when the function was added or last used.  Some have
comments saying things like the devm_ version is being used (so it
seemed reasonable to me to delete the plain version if no one uses it).

For each one I've checked _when_ it was last used and not deleted
anything that's been used in the last few years; I've not deleted
anything which has been recently added or only recently unused.

That level seems to have been fine on the other ~300 clean up 
patches other maintainers have taken; you seem to be after something
different - I'm fine to add that if you can just explain what
you want.

Just point me in the right direction and I can have more of a dig.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux