* Mario Limonciello <superm1@xxxxxxxxxx> wrote: > > and ... I'm sure you knew this was coming, but we should probably > > move *all* basic FCH_PM definitions into that header, such as > > SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so? > > I'll double check how it's actually used against the documentation to > see if this makes sense. > > If it's only mapping a subset of registers for the PIIX4 driver use > bringing the definition out to a header used by other drivers that > might need a larger or smaller subset to be mapped might not make > sense. Sounds good to me! Ingo