On 4/12/25 15:15, Ingo Molnar wrote:
* Mario Limonciello <superm1@xxxxxxxxxx> wrote:
SB800 is pre-Zen stuff. It's "before my time" - I guess that's the
precursor to FCH being in the SoC but has the same functionality.
So I'm thinking <asm/amd_fch.h>.
I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these
days?
But yeah, <asm/amd_fch.h> sounds good to me too.
OK.
Boris?
and ... I'm sure you knew this was coming, but we should probably move
*all* basic FCH_PM definitions into that header, such as
SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so?
I'll double check how it's actually used against the documentation to
see if this makes sense.
If it's only mapping a subset of registers for the PIIX4 driver use
bringing the definition out to a header used by other drivers that might
need a larger or smaller subset to be mapped might not make sense.
