On Tue, 17 Jun 2025 at 12:22, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>>
> The tests are already in their own patches: patches 4 and 5. Yes, this patchset
> has a negative diffstat once you subtract them.
Yes, the patches were separate, but my point stands.
Let me repeat that part of the email since you seem to have missed it:
> If I see a pull request that only adds new tests, it's a no-brainer.
>
> If I see a pull request that only re-organizes the code and the
> diffstat just just renames with some small updates for new locations,
> it's a no-brainer.
>
> If I see a pull request that does both, it's a pain in the arse,
> because then I need to start to look into individual commits and go
> "which does what".
IOW, I really prefer pull requests to do clearly separate things too
when we're talking re-organization. Or at the very least spell things
out *very* clearly.
Otherwise I have to waste time just to go split things out _anyway_.
Linus
