On Mon, 16 Jun 2025 at 23:05, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> An additional note on testing: [..]
Talking about testing - when adding test scripts, can you do it as a
separate thing entirely - either before or after?
As it is, this code movement is hard to judge just because the stats
are all messed up with new tests:
77 files changed, 4012 insertions(+), 1756 deletions(-)
that's 2k+ new lines of code that pretty much entirely hides the
question of "did this code movement result in a simpler / same / more
complex end result".
So in general, I'd really prefer big re-organizations to be *separate*
from new code changes.
It's just a pain to review renaming when it's mixed up with other
changes - whether renaming variables or whole files.
And that's as true on an individual commit level (we try to avoid
renaming things *and* making other changes in one go) as it is on a
pull request level.
If I see a pull request that only adds new tests, it's a no-brainer.
If I see a pull request that only re-organizes the code and the
diffstat just just renames with some small updates for new locations,
it's a no-brainer.
If I see a pull request that does both, it's a pain in the arse,
because then I need to start to look into individual commits and go
"which does what".
Linus
