On 05/05/2025 17:48, Krzysztof Kozlowski wrote: > On 05/05/2025 14:55, Pavitrakumar M wrote: >> From: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> >> >> Add DT bindings related to the SPAcc driver for Documentation. >> DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto >> Engine is a crypto IP designed by Synopsys. >> >> Co-developed-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> >> Signed-off-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx> >> Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx> >> Acked-by: Ruud Derwig <Ruud.Derwig@xxxxxxxxxxxx> > > > I do not see any improvements. It seems you ignored all comments, not > single one was responded to or addressed. > > NAK > > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > Hm, actually I see now email you responded to some but ignored several others, so still a no. Best regards, Krzysztof