On Thu, Apr 24, 2025 at 09:17:39AM -0700, Eric Biggers wrote: > > Why aren't the POLYVAL changes in their own patch series? Yes they really should have been part of the previous series since it's not lib/crypto code. I'll split them out. > Touching SHA-256 (which again, I'm currently working on fixing properly, so I > keep having to rebase on top of your random changes which will be superseded > anyway) also seems to be unnecessary. Sorry about that. But sha256 happens to be the only other lib/crypto hash algorithm that I could take the code from. It also turns out to generate x86 code that's much better than poly1305 (I actually started out with poly1305, but switched over to sha256 after I saw how horrible sha256 looked with the poly1305 partial block handling). Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
