On Thu, Apr 24, 2025 at 09:14:31AM -0700, Eric Biggers wrote: > > Use 'raw_key' instead of 'key' when referring to the 16-byte polynomial hash key > which is the first half of the full 32-byte Poly1305 one-time key. OK I'll change that. > > + desc->buflen = BLOCK_HASH_UPDATE(&poly1305_block, &desc->state, > > + src, nbytes, POLY1305_BLOCK_SIZE, > > + desc->buf, desc->buflen); > > } > > EXPORT_SYMBOL_GPL(poly1305_update_generic); > > Again, should just write this out without the weird macro, which is also being > used incorrectly here. If you have a better way of abstracting out the partial block handling, please let me know. As to using it incorrectly, could you please be more specific? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
