On Fri, Apr 25, 2025 at 11:42:37AM +0800, Herbert Xu wrote: > On Thu, Apr 24, 2025 at 08:36:47AM -0700, Eric Biggers wrote: > > > > So now users randomly need to "clone" the tfm for each request. Which is easy > > to forget to do (causing key reuse), and also requires a memory allocation. > > It appears that we have exactly one user of the Crypto API poly1305 > other than IPsec, and that is bcachefs. But yes I forgot to convert > it to the new interface. It should just use the library interface > since it doesn't support any other keyed algorithms so there is zero > point in the abstraction. I already did that. See commit 4bf4b5046de0 in mainline. - Eric