On Thu, Apr 24, 2025 at 08:36:47AM -0700, Eric Biggers wrote: > > So now users randomly need to "clone" the tfm for each request. Which is easy > to forget to do (causing key reuse), and also requires a memory allocation. It appears that we have exactly one user of the Crypto API poly1305 other than IPsec, and that is bcachefs. But yes I forgot to convert it to the new interface. It should just use the library interface since it doesn't support any other keyed algorithms so there is zero point in the abstraction. Come to think of it, the IPsec usage is pointless too since the only algorithm that can show up here is poly1305. So I will convert it to the library interface too. > Well, good thing most of the users are just using the Poly1305 library instead > of the broken Crypto API mess. If you only support one algorithm, there is no point in using shash. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
