Hi, Jens
在 2025/8/3 5:42, Jens Axboe 写道:
On 8/2/25 12:29 PM, Jens Axboe wrote:
On 8/2/25 11:25 AM, Yu Kuai wrote:
Hi, Jens
Please consider pulling following changes on your block-6.17 branch,
this pull request contains:
- mddev null-ptr-dereference fix, by Erkun
- md-cluster fail to remove the faulty disk regression fix, by Heming
- minor cleanup, by Li Nan
- mdadm lifetime regression fix reported by syzkaller, by Yu Kuai
- experimental feature: introduce new lockless bitmap, by Yu Kuai
Why was this sent in so late? You're at least a week later sending in
big changes for the merge window, as we're already half way through it.
Generally anything big should land in my tree a week before the merge
window OPENS, not a week into it.
I took a closer look, because perhaps you just sent in the pull request
pretty late. And it's a bit hard to tell because it looks like you
rebased this code (why?), but at least the lockless bitmap code looks
like it was finished up inside the merge window. That looks late. The
rest looks more reasonably timed, just rebased for some reason.
If I'm going to get yelled at by a traveling Linus, there better be a
good reason for it. In other words, is there a justification for the
lockless bitmap code being in there?
Apologies for the late submission - this was unintentional. The core changes
were ready before 6.15, but the final llbitmap patch got delayed due to
review
backlog.
About the last patch:
- all feedback are addressed 2 weeks ago
- still waiting formal Reviewed-by tag, not sure why, possibly due to
this patch
is huge.
About the rebase, this is because llbitmap set has conflicts with other
patches
during the period, and I sent a new version and just pick it last night.
I do take a bet sending this pr last night, and hoping llbitmap won't
delayed to
next merge window again. However, I fully understand if this misses 6.17,
I'm prepared to defer to 6.18.
Thanks,
Kuai
