On 8/2/25 12:29 PM, Jens Axboe wrote: > On 8/2/25 11:25 AM, Yu Kuai wrote: >> Hi, Jens >> >> Please consider pulling following changes on your block-6.17 branch, >> this pull request contains: >> >> - mddev null-ptr-dereference fix, by Erkun >> - md-cluster fail to remove the faulty disk regression fix, by Heming >> - minor cleanup, by Li Nan >> - mdadm lifetime regression fix reported by syzkaller, by Yu Kuai >> - experimental feature: introduce new lockless bitmap, by Yu Kuai > > Why was this sent in so late? You're at least a week later sending in > big changes for the merge window, as we're already half way through it. > Generally anything big should land in my tree a week before the merge > window OPENS, not a week into it. I took a closer look, because perhaps you just sent in the pull request pretty late. And it's a bit hard to tell because it looks like you rebased this code (why?), but at least the lockless bitmap code looks like it was finished up inside the merge window. That looks late. The rest looks more reasonably timed, just rebased for some reason. If I'm going to get yelled at by a traveling Linus, there better be a good reason for it. In other words, is there a justification for the lockless bitmap code being in there? -- Jens Axboe
