Re: [PATCH 3/5] bcache, tracing: Do not truncate orig_sector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 22, 2025 at 10:54:02AM +0800, Bart Van Assche wrote:
> On 7/15/25 9:52 AM, Bart Van Assche wrote:
> > Change the type of orig_sector from dev_t (unsigned int) into sector_t (u64)
> > to prevent truncation of orig_sector by the tracing code.
> > 
> > Cc: Kent Overstreet <kent.overstreet@xxxxxxxxx>
> > Fixes: cafe56359144 ("bcache: A block layer cache")
> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> > ---
> >   include/trace/events/bcache.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/bcache.h b/include/trace/events/bcache.h
> > index 899fdacf57b9..d0eee403dc15 100644
> > --- a/include/trace/events/bcache.h
> > +++ b/include/trace/events/bcache.h
> > @@ -16,7 +16,7 @@ DECLARE_EVENT_CLASS(bcache_request,
> >   		__field(unsigned int,	orig_major		)
> >   		__field(unsigned int,	orig_minor		)
> >   		__field(sector_t,	sector			)
> > -		__field(dev_t,		orig_sector		)
> > +		__field(sector_t,	orig_sector		)
> >   		__field(unsigned int,	nr_sector		)
> >   		__array(char,		rwbs,	6		)
> >   	),
> 
> Hi Coly,
> 
> Can you please help with reviewing the two bcache patches in this patch
> series? Apparently you didn't get Cc-ed automatically by
> scripts/get_maintainer.pl. See also
> https://lore.kernel.org/linux-block/20250715165249.1024639-1-bvanassche@xxxxxxx/.

Done. Thanks.

Coly Li




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux