On Tue, Jul 15, 2025 at 09:52:38AM +0800, Bart Van Assche wrote:
> sector_t is a synonym for u64 and all architectures define u64 as unsigned
> long long. Hence, it is not necessary to cast type sector_t to unsigned
> long long. Remove the superfluous casts to improve compile-time type checking.
>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Acked-by: Coly Li <colyli@xxxxxxxxxx>
Thanks.
Coly Li
> ---
> include/trace/events/bcache.h | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/trace/events/bcache.h b/include/trace/events/bcache.h
> index d0eee403dc15..697e0f80d17c 100644
> --- a/include/trace/events/bcache.h
> +++ b/include/trace/events/bcache.h
> @@ -33,9 +33,9 @@ DECLARE_EVENT_CLASS(bcache_request,
>
> TP_printk("%d,%d %s %llu + %u (from %d,%d @ %llu)",
> MAJOR(__entry->dev), MINOR(__entry->dev),
> - __entry->rwbs, (unsigned long long)__entry->sector,
> + __entry->rwbs, __entry->sector,
> __entry->nr_sector, __entry->orig_major, __entry->orig_minor,
> - (unsigned long long)__entry->orig_sector)
> + __entry->orig_sector)
> );
>
> DECLARE_EVENT_CLASS(bkey,
> @@ -107,7 +107,7 @@ DECLARE_EVENT_CLASS(bcache_bio,
>
> TP_printk("%d,%d %s %llu + %u",
> MAJOR(__entry->dev), MINOR(__entry->dev), __entry->rwbs,
> - (unsigned long long)__entry->sector, __entry->nr_sector)
> + __entry->sector, __entry->nr_sector)
> );
>
> DEFINE_EVENT(bcache_bio, bcache_bypass_sequential,
> @@ -144,7 +144,7 @@ TRACE_EVENT(bcache_read,
>
> TP_printk("%d,%d %s %llu + %u hit %u bypass %u",
> MAJOR(__entry->dev), MINOR(__entry->dev),
> - __entry->rwbs, (unsigned long long)__entry->sector,
> + __entry->rwbs, __entry->sector,
> __entry->nr_sector, __entry->cache_hit, __entry->bypass)
> );
>
> @@ -175,7 +175,7 @@ TRACE_EVENT(bcache_write,
>
> TP_printk("%pU inode %llu %s %llu + %u hit %u bypass %u",
> __entry->uuid, __entry->inode,
> - __entry->rwbs, (unsigned long long)__entry->sector,
> + __entry->rwbs, __entry->sector,
> __entry->nr_sector, __entry->writeback, __entry->bypass)
> );
>
> @@ -243,8 +243,7 @@ TRACE_EVENT(bcache_journal_write,
>
> TP_printk("%d,%d %s %llu + %u keys %u",
> MAJOR(__entry->dev), MINOR(__entry->dev), __entry->rwbs,
> - (unsigned long long)__entry->sector, __entry->nr_sector,
> - __entry->nr_keys)
> + __entry->sector, __entry->nr_sector, __entry->nr_keys)
> );
>
> /* Btree */
>
