On Mon, Jul 21, 2025 at 09:42:23AM +0200, Christoph Hellwig wrote: > On Sun, Jul 20, 2025 at 11:40:34AM -0700, Keith Busch wrote: > > From: Keith Busch <kbusch@xxxxxxxxxx> > > > > The req_iterator just happens to have a similar fields to what the dma > > iterator needs, but we're not necessarily iterating a bio_vec here. Have > > the dma iterator define its private fields directly. It also helps to > > remove eyesores like "iter->iter.iter". > > Going back to this after looking at the later patches. The level > for which this iter exists is only called blk_map_* as there is > nothing dma specific about, just mapping to physical addresses. > > So maybe call it blk_map_iter instead? But the structure yields "dma_addr_t" type values to the consumer. Whether those are physical addresses or remapped io virtual addresses, they're still used for direct memory access, so I think the name as-is is a pretty good fit.
