Re: [PATCH] loop: use kiocb helpers to fix lockdep warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2025 at 08:31:56PM +0800, Ming Lei wrote:
> On Wed, Jul 16, 2025 at 8:20 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jul 16, 2025 at 07:48:08PM +0800, Ming Lei wrote:
> > > This patch fixes the issue by using the AIO-specific helpers
> > > `kiocb_start_write()` and `kiocb_end_write()`. These functions are
> > > designed to be used with a `kiocb` and manage write sequencing
> > > correctly for asynchronous I/O without introducing the problematic
> > > lock dependency.
> >
> > Maybe explain what it actually does.  That is drop and reacquire the
> > lockdep notion of a held lock, because the process is not holding it
> > but instead handing it of to the one handling the completion of the
> > asynchronous I/O.
> >
> > The change looks fine to me, but this commit log is rather confusing.
> 
> It is actually the typical use case for aio, please see use in fs/aio.c.

I know, that's not the point.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux