Re: [PATCH v3 1/7] block: Improve blk_crypto_fallback_split_bio_if_needed()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/07/2025 21:10, Bart Van Assche wrote:
Remove the assumption that bv_len is a multiple of 512 bytes since this is
not guaranteed by the block layer. This assumption may cause this function
to return a smaller value than it should. This is harmless from a
correctness point of view but may result in suboptimal performance.

Note: unsigned int is sufficient for num_bytes since bio_for_each_segment()
yields at most one page per iteration and since PAGE_SIZE * BIO_MAX_VECS
fits in an unsigned int.

Suggested-by: John Garry <john.g.garry@xxxxxxxxxx>
Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")

is this really a fix?

Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>

Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux