On 14.07.25 18:43, Bart Van Assche wrote:
> On 7/14/25 7:38 AM, Johannes Thumshirn wrote:
>> + TP_printk("%d,%d zone %u, BIO %llu + %u",
>> + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->zno,
>> + (unsigned long long)__entry->sector,
>> + __entry->nr_segs)
>
> Fifteen years ago it was essential in kernel code to cast u64 values
> when formatting these with %llu but that's no longer necessary today. I
> think that the "unsigned long long" cast can be left out since nowadays
> u64 is a synonym for unsigned long long in the Linux kernel. Otherwise
> this patch looks good to me.
If you look at the rest of include/trace/events/block.h every other
TP_printk() invocation that has sector is doing this cast.
