Re: [PATCH v2 5/5] block: add trace messages to zone write plugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/14/25 7:38 AM, Johannes Thumshirn wrote:
+	TP_printk("%d,%d zone %u, BIO %llu + %u",
+		  MAJOR(__entry->dev), MINOR(__entry->dev), __entry->zno,
+		  (unsigned long long)__entry->sector,
+		  __entry->nr_segs)

This output format is confusing. All other block layer tracing code
uses the notation <sector> + ... to indicate a starting sector and a
length in sectors. Is the segment information relevant enough to
include it in the tracing output? If so, please use another way to
report the number of segments, e.g. "BIO %llu, nr_segs %u".

Thanks,

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux