On 7/10/25 6:59 PM, Johannes Thumshirn wrote: >>> + case REQ_OP_ZONE_APPEND: >>> + rwbs[i++] = 'Z'; >>> + rwbs[i++] = 'A'; >>> + break; >>> + case REQ_OP_ZONE_RESET: >>> + case REQ_OP_ZONE_RESET_ALL: >>> + rwbs[i++] = 'Z'; >>> + rwbs[i++] = 'R'; >> >> I would really prefer the ability to distinguish single zone reset and all >> zones reset... Are we limited to 2 chars for the operation name ? If not, >> making REQ_OP_ZONE_RESET_ALL be "ZRA" would be better I think. If you want to >> preserve the 2 chars for the op name, then maybe ... no goo idea... Naming is >> hard :) > > Again, I'd prefer the 2 chars version, as a RESET ALL can be > distinguished form a plain RESET by the number of sectors (see patch > 4/5) and we would need to bump RWBS_LEN. Hu ? both reset and reset all use 0 sectors for the BIO. Reset all always also use sector == 0, so that means that you cannot distinguish a reset all from a single zone reset of the first zone... OK, this is really just that. But still, given the different op code, a different name would be nice. > > But of cause this as well is personal preference and I can go either > way. Whatever is preferred by everyone. -- Damien Le Moal Western Digital Research
