Re: [PATCH 1/5] blktrace: add zoned block commands to blk_fill_rwbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/9/25 8:47 PM, Johannes Thumshirn wrote:
> Add zoned block commands to blk_fill_rwbs:
> 
> - ZONE APPEND will be decoded as 'ZA'
> - ZONE RESET and ZONE RESET ALL will be decoded as 'ZR'
> - ZONE FINISH will be decoded as 'ZF'
> - ZONE OPEN will be decoded as 'ZO'
> - ZONE CLOSE will be decoded as 'ZC'
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> ---
>  kernel/trace/blktrace.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 3f6a7bdc6edf..f1dc00c22e37 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1875,6 +1875,27 @@ void blk_fill_rwbs(char *rwbs, blk_opf_t opf)
>  	case REQ_OP_READ:
>  		rwbs[i++] = 'R';
>  		break;

May be enclode this new hunk under a #ifdef CONFIG_BLK_DEV_ZONED ?

> +	case REQ_OP_ZONE_APPEND:
> +		rwbs[i++] = 'Z';
> +		rwbs[i++] = 'A';
> +		break;
> +	case REQ_OP_ZONE_RESET:
> +	case REQ_OP_ZONE_RESET_ALL:
> +		rwbs[i++] = 'Z';
> +		rwbs[i++] = 'R';

I would really prefer the ability to distinguish single zone reset and all
zones reset... Are we limited to 2 chars for the operation name ? If not,
making REQ_OP_ZONE_RESET_ALL be "ZRA" would be better I think. If you want to
preserve the 2 chars for the op name, then maybe ... no goo idea... Naming is
hard :)

> +		break;
> +	case REQ_OP_ZONE_FINISH:
> +		rwbs[i++] = 'Z';
> +		rwbs[i++] = 'F';
> +		break;
> +	case REQ_OP_ZONE_OPEN:
> +		rwbs[i++] = 'Z';
> +		rwbs[i++] = 'O';
> +		break;
> +	case REQ_OP_ZONE_CLOSE:
> +		rwbs[i++] = 'Z';
> +		rwbs[i++] = 'C';
> +		break;
>  	default:
>  		rwbs[i++] = 'N';
>  	}


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux