Re: [PATCH blktests RFC 2/2] check: abort test run when a test case exits by "set -e" error-checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On May 30, 2025 / 09:00, Bart Van Assche wrote:
> On 5/30/25 12:54 AM, Shin'ichiro Kawasaki wrote:
> > +	if grep --quiet "set -e" "tests/${TEST_NAME}"; then
> > +		ERR_EXIT=1
> > +	fi
> 
> This is fragile. Please don't do this. My opinion is that test scripts
> should declare it explicitly if they exit if something unexpected has
> been encountered rather than trying to derive this with grep.

I see. I will introduce the global flag, like ERREXIT=1 or something.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux