Re: [PATCH blktests RFC 2/2] check: abort test run when a test case exits by "set -e" error-checking

[Bart Van Assche <bvanassche@xxxxxxx>]

On 5/30/25 12:54 AM, Shin'ichiro Kawasaki wrote:
> +	if grep --quiet "set -e" "tests/${TEST_NAME}"; then
> +		ERR_EXIT=1
> +	fi

This is fragile. Please don't do this. My opinion is that test scripts
should declare it explicitly if they exit if something unexpected has
been encountered rather than trying to derive this with grep.

Thanks,

Bart.